Hi, On Tue, Dec 14, 2010 at 07:44:35PM +0100, Ivo Van Doorn wrote: > >> The Queue names were incorrectly copied from the legacy drivers, > >> as a result the queue names were inversed to what was expected. > >> > >> This renames the queues using this mapping: > >> QID_AC_BK -> QID_AC_VO (priority 0) > >> QID_AC_BE -> QID_AC_VI (priority 1) > >> QID_AC_VI -> QID_AC_BE (priority 2) > >> QID_AC_VO -> QID_AC_BK (priority 3) > >> > >> Note that this was a naming problem only, which didn't affect > >> the assignment of frames to their respective queues. > >> > >> Signed-off-by: Ivo van Doorn <IvDoorn@xxxxxxxxx> > > > > Ivo, due to the latest info from Ralink I'd say we should drop this patch > > and instead introduce a mac80211_to_rt2x00_qid mapper that maps from > > ieee80211_ac_numbers to data_queue_qid. > > > > This patch doesn't cause any harm, but we would have to revert it partly > > if we introduce the queue mapping as needed by the rt2x00 devices. > > I don't agree, this patch can safely be applied, since the mapping > is in the endpoint assignment, rather the register value usage, > I think the more optimal solution is fixing rt2x00usb_assign_endpoints. > In there it currently assigns endpoints assuming the first endpoint > is the highest priority, while we should be able to simply swap that > to invert the logic. Inverting is not enough since the first OUT EP (EP1) is AC_BE, while AC_BK (lowest priority) is EP2. This corresponds to the to the AC -> ACI mapping from 802.11 Table 7-36 in section "7.3.2.29 EDCA Parameter Set element". Probably the rationale is that ACI value 0 should be the "default" AC. Johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
