Search Linux Wireless

Re: [PATCH] mac80211: avoid calling ieee80211_work_work unconditionally

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 13, 2010 at 9:34 AM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Mon, 2010-12-13 at 09:29 -0800, Luis R. Rodriguez wrote:
>> On Mon, Dec 13, 2010 at 5:43 AM, Herton Ronaldo Krzesinski
>> <herton@xxxxxxxxxxxxxxx> wrote:
>> > On suspend, there might be usb wireless drivers which wrongly trigger
>> > the warning in ieee80211_work_work. If an usb driver doesn't have a
>> > suspend hook, the usb stack will disconnect the device. On disconnect,
>> > a mac80211 driver calls ieee80211_unregister_hw, which calls dev_close,
>> > which calls ieee80211_stop, and in the end calls ieee80211_work_purge->
>> > ieee80211_work_work.
>> >
>> > The problem is that this call to ieee80211_work_purge comes after
>> > mac80211 is suspended, triggering the warning even when we don't have
>> > work queued in work_list (the expected case when already suspended),
>> > because it always calls ieee80211_work_work.
>> >
>> > So, just call ieee80211_work_work in ieee80211_work_purge if we really
>> > have to abort work. This addresses the warning reported at
>> > https://bugzilla.kernel.org/show_bug.cgi?id=24402
>> >
>> > Signed-off-by: Herton Ronaldo Krzesinski <herton@xxxxxxxxxxxxxxx>
>>
>> Cc: stable@xxxxxxxxxx ?
>
> It's just a warning, do we really want to bother?

Why not, it pollutes logs.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux