Rafal, -----Original Message----- >From: RafaÅ MiÅecki <zajec5@xxxxxxxxx> >Sent: Dec 9, 2010 6:06 AM >To: ikorot@xxxxxxxxxxxxx >Cc: Larry Finger <Larry.Finger@xxxxxxxxxxxx>, Hauke Mehrtens <hauke@xxxxxxxxxx>, linux-wireless@xxxxxxxxxxxxxxx, b43-dev@xxxxxxxxxxxxxxxxxxx >Subject: Re: [PATCH 1/4] b43: N-PHY: update init tables > >2010/12/8 <ikorot@xxxxxxxxxxxxx>: >> Larry, >> >> >> -----Original Message----- >>>From: Larry Finger <Larry.Finger@xxxxxxxxxxxx> >>>Sent: Dec 7, 2010 12:00 PM >>>To: ikorot@xxxxxxxxxxxxx >>>Cc: Hauke Mehrtens <hauke@xxxxxxxxxx>, linux-wireless@xxxxxxxxxxxxxxx, b43-dev@xxxxxxxxxxxxxxxxxxx >>>Subject: Re: [PATCH 1/4] b43: N-PHY: update init tables >>> >>>On 12/07/2010 01:49 PM, ikorot@xxxxxxxxxxxxx wrote: >>>>> One reason is that these tables changed from non-zero to zero values between >>>>> Broadcom driver 4.174.64.19 and 5.10.56.46. As they might change again, I think >>>>> we should retain the full version. >>>> >>>> Is there a way to check for version of the driver? >>>> This way whoever uses old one won't be screwed... >>> >>>That will not be a problem as no older version of b43 works at all with b43. To >>>help you understand this change, when the 4.174.64.19 Broadcom driver was >>>reverse-engineered, the tables had non-zero values. Rafel later compared the >>>trace dumps of b43 with the latest version of wl and found that the values are >>>now zero. When I rechecked driver 5.10.56.46, I found them to be zero there as >>>well and changed the specs. >> >> Well, it maybe feasible to keep the old values and check >> the version of the driver, since you are saying yourself >> that the value might be changing in the future. >> Maybe for couple of releases only? > >Sorry, but I don't understand that at all. What do you mean by version >of the driver? What driver? #if B43_VERSION <= x.x.x.x // table initialized to some values #else //table initialized to 0's #endif > >b43 comes with tables built in, there is no way b43 could use tables >from other version of b43... Thank you. > >-- >RafaÅ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
