On Thu, 2010-12-09 at 15:23 +0100, RafaÅ MiÅecki wrote:
> W dniu 9 grudnia 2010 15:19 uÅytkownik Michael BÃsch <mb@xxxxxxxxx> napisaÅ:
> > On Thu, 2010-12-09 at 15:13 +0100, RafaÅ MiÅecki wrote:
> >> W dniu 9 grudnia 2010 15:12 uÅytkownik RafaÅ MiÅecki <zajec5@xxxxxxxxx> napisaÅ:
> >> > W dniu 7 grudnia 2010 22:08 uÅytkownik Michael BÃsch <mb@xxxxxxxxx> napisaÅ:
> >> >> On Tue, 2010-12-07 at 21:55 +0100, RafaÅ MiÅecki wrote:
> >> >>> Signed-off-by: RafaÅ MiÅecki <zajec5@xxxxxxxxx>
> >> >>> ---
> >> >>> drivers/net/wireless/b43/main.c | 6 ++++++
> >> >>> drivers/net/wireless/b43/phy_common.c | 7 +++++++
> >> >>> drivers/net/wireless/b43/phy_common.h | 2 ++
> >> >>> drivers/net/wireless/b43/phy_n.c | 7 -------
> >> >>> 4 files changed, 15 insertions(+), 7 deletions(-)
> >> >>>
> >> >>> diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
> >> >>> index fa48803..670fd7b 100644
> >> >>> --- a/drivers/net/wireless/b43/main.c
> >> >>> +++ b/drivers/net/wireless/b43/main.c
> >> >>> @@ -1150,6 +1150,12 @@ void b43_wireless_core_reset(struct b43_wldev *dev, u32 flags)
> >> >>>
> >> >>> flags |= B43_TMSLOW_PHYCLKEN;
> >> >>> flags |= B43_TMSLOW_PHYRESET;
> >> >>> + if (dev->phy.type == B43_PHYTYPE_N) {
> >> >>> + if (b43_channel_type_is_40mhz(dev->phy.channel_type))
> >> >>
> >> >> Is channel_type already set at this time?
The more I think about this, the wronger it looks to me.
Why do we care about the channel type at reset time anyway?
I guess the channel type is a parameter that can change any time on an
operating card. So just unconditionally set B43_TMSLOW_PHYCLKSPEED_80MHZ
at reset time and set the correct TMSLOW bits later when channel_type is
actually changed. That seems to be the only sane thing to do.
I guess we don't want to fully reset the device when channel_type
changes, do we?
--
Greetings Michael.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
