On Tue, 2010-11-30 at 17:43 -0600, Jon Mason wrote: > pci_restore_state only ever returns 0, thus there is no benefit in > having it return any value. Also, a large majority of the callers do > not check the return code of pci_restore_state. Make the > pci_restore_state a void return and avoid the overhead. It does kind of make me nervous that (basically) no one ever checks the return code from the PCI config space accessors, even though in theory they can fail. This code being but one example. /end random comment :) cheers
Attachment:
signature.asc
Description: This is a digitally signed message part