Search Linux Wireless

Re: [PATCH 2/3] ath9k: Fix power save count imbalance on ath_radio_enable()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 3, 2010 at 5:20 PM, Luis R. Rodriguez
<lrodriguez@xxxxxxxxxxx> wrote:
> Upon a failure we never call ath9k_ps_restore() on ath_radio_enable(),
> this will throw off the sc->ps_usecount. When the sc->ps_usecount
> is > 0 we never put the chip to full sleep. This drains battery,
> and will also make the chip fail upon resume with:
>
> ath: Starting driver with initial channel: 5745 MHz
> ath: timeout (100000 us) on reg 0x7000: 0xdeadbeef & 0x00000003 != 0x00000000
>
> This would make the chip useless upon resume.
>
> I cannot prove this can happen but in theory it is so best to
> avoid this race completely and not have users complain about
> a broken device after resume.
>
> Cc: stable@xxxxxxxxxx
> Cc: Paul Stewart <pstew@xxxxxxxxxx>
> Cc: Amod Bodas <amod.bodas@xxxxxxxxxxx>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@xxxxxxxxxxx>

John, this one is for you, sorry I failed to send it to you. And
Johannes, sorry, I forgot to remove you from my send script :)

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux