2010/12/2 Larry Finger <Larry.Finger@xxxxxxxxxxxx>: > + Â Â Â Â Â Â Â Â Â Â Â revision = buf[SSB_SPROMSIZE_WORDS_R4 - 1] & 0x00FF; Should we define macro for that, to do not duplicate code from this part: sprom_extract(...): out->revision = in[size - 1] & 0x00FF; ? I don't vote for any solution, but maybe one should be preferred and you just didn't notice that? I noone have problem with this liiitle duplication, ignore me ;) -- RafaÅ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html