Johannes, On Tue, Nov 30, 2010 at 10:19 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Tue, 2010-11-30 at 17:58 -0800, Javier Cardona wrote: >> This patch adds the capability to the mesh stack to receive vendor >> specific information elements from userspace. When a vendor specific >> IE is set via nl80211, the mesh stack will configure the mesh beacon to >> advertise that a vendor specific path selection and metric is in use. >> This is accordance with the Extensible Path Selection Framework >> specified in version 7.0 of the 802.11s draft. > >> @@ -1709,6 +1709,7 @@ static int nl80211_addset_beacon(struct sk_buff *skb, struct genl_info *info) >> return -EINVAL; >> >> if (dev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP && >> + dev->ieee80211_ptr->iftype != NL80211_IFTYPE_MESH_POINT && >> dev->ieee80211_ptr->iftype != NL80211_IFTYPE_P2P_GO) >> return -EOPNOTSUPP; > > I'm not convinced that letting userspace set the *entire* beacon is the > right way to do it? Wouldn't it make more sense to allow it to specify > vendor-specific IEs (like IBSS), and the fact that vendor selection > protocol is used? It seems to me that somebody may want to have vendor > IEs while using the default protocols? Yes, agreed. We'll investigate a way to provide a protocol switch (maybe a new NL80211_CMD_SET_MESH_PARAMS) + a vendor specific IE (NL80211_CMD_SET_MGMT_EXTRA_IE would have been ideal, but I see it's gone). Thanks! Javier -- Javier Cardona cozybit Inc. http://www.cozybit.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
