On 2010-11-30 2:39 AM, Joe Perches wrote: > On Mon, 2010-11-29 at 23:41 +0100, Felix Fietkau wrote: >> On 2010-11-29 7:07 AM, Peter Stuge wrote: >> > Luis R. Rodriguez wrote: >> >> On Sun, Nov 28, 2010 at 3:53 PM, Joe Perches <joe@xxxxxxxxxxx> wrote: >> >> > Make the function name match the function purpose. >> >> > ath_debug is a debug only facility. >> >> > ath_print seems too generic a name for a debug only use. >> >> Nack, I don't see the point. >> > >> > The point is to improve readability. I like the patch. >> And how exactly does this improve readability? Don't get me wrong, I >> generally like to see more cleanups merged to the ath/ath9k drivers >> (they do need it, after all). > > It's considered polite to cc the patch author. Sorry, I forgot to add you back. The Cc list was cleared somewhere in this thread and I added a few entries back, but apparently accidentally dropped some of them again. > print is generic, debug is specific. > This function has a specific use for debugging > not a generic use all for logging. > > If it was ath_print(level, etc) with KERN_<level> > passed as the first argument that'd be similar > to other kernel calls. As is, it's not. > >> But in my opinion, simple renaming churn like this does nothing but >> annoy people who want to get other work done at the same time. > > This sort of thing can be done when other changes have > just been merged to minimize conflicts. > >> Consider the large number of lines touched (and the potential merge >> conflicts with other code because of that), relative to the microscopic >> aesthetic gain (if any). >> >> Instead I'd like to see more cleanups that go beyond trivial function >> renames. > > I gauge my willingness to spend time on subsystems on > the maintainers willingness to merge things that improve > readability and correctness. I'm not trying to discourage you from spending time on improving this code, just doubting the usefulness of such simple function renames. - Felix -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
