On Mon, Nov 29, 2010 at 2:41 PM, Felix Fietkau <nbd@xxxxxxxxxxx> wrote: > On 2010-11-29 7:07 AM, Peter Stuge wrote: >> Luis R. Rodriguez wrote: >>> On Sun, Nov 28, 2010 at 3:53 PM, Joe Perches <joe@xxxxxxxxxxx> wrote: >>> > Make the function name match the function purpose. >>> > ath_debug is a debug only facility. >>> > ath_print seems too generic a name for a debug only use. >>> >>> Nack, I don't see the point. >> >> The point is to improve readability. I like the patch. > And how exactly does this improve readability? Don't get me wrong, I > generally like to see more cleanups merged to the ath/ath9k drivers > (they do need it, after all). > > But in my opinion, simple renaming churn like this does nothing but > annoy people who want to get other work done at the same time. > Consider the large number of lines touched (and the potential merge > conflicts with other code because of that), relative to the microscopic > aesthetic gain (if any). > > Instead I'd like to see more cleanups that go beyond trivial function > renames. Thanks for putting it so clearly. Agreed. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
