On Mon, Nov 29, 2010 at 04:09:09PM +0100, Johannes Berg wrote: > On Mon, 2010-11-29 at 15:54 +0100, Johannes Stezenbach wrote: > > ieee80211_tx_status() documentation says "This function may not be > > called in IRQ context", and it is called by rt2800usb > > from a workqueue context. Thus it needs to call > > netif_rx_ni() instead of netif_rx(). > > This change fixes the "NOHZ: local_softirq_pending 08" > > messages I've been getting with rt2800usb. > > > - netif_rx(skb2); > > + netif_rx_ni(skb2); > > That's kinda pointless though for drivers that already call it from a > tasklet or similar -- how about instead adding an > ieee80211_tx_status_ni() inline along the lines of ieee80211_rx_ni()? It gets confusing... There already is ieee80211_tx_status_irqsafe(), but you want a third option, right? Johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html