On Monday 29 November 2010 11:09:16 Johannes Berg wrote: > From: Johannes Berg <johannes.berg@xxxxxxxxx> > > The RX aggregation locking documentation was > wrong, which led Christian to also code the > timer timeout handling for it somewhat wrongly. > > Fix the documentation, the two places that > need to hold the reorder lock across accesses > to the structure, and the debugfs code that > should just use RCU. > > Also, remove acquiring the sta->lock across > reorder timeouts since it isn't necessary, and > change a few places to GFP_KERNEL because the > code path here doesn't need atomic allocations > as I noticed when reviewing all this. > > Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx> Acked-by: Christian Lamparter <chunkeey@xxxxxxxxxxxxxx> > --- > Christian, do you remember what else we needed to do here? Sure, I put a "helpful" comment in commit 15943a72c: "mac80211: temporarily disable reorder release timer" including a "list" of things that need to be considered: http://marc.info/?l=linux-wireless&m=128656352920957 But, one thing, I think I finally found out why the device keeps disconnecting for some users: http://www.spinics.net/lists/linux-wireless/msg56678.html and I need to fix that first :( Best regards, Chr -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
