> -----Original Message----- > From: Juuso Oikarinen [mailto:juuso.oikarinen@xxxxxxxxx] > Sent: Friday, November 26, 2010 11:57 AM > To: Levi, Shahar > Cc: linux-wireless@xxxxxxxxxxxxxxx; Luciano Coelho > Subject: Re: [PATCH ] wl12xx: BA receiver support > > On Wed, 2010-11-24 at 18:33 +0200, ext Shahar Levi wrote: > > > > +int wl1271_op_ampdu_action(struct ieee80211_hw *hw, struct > ieee80211_vif *vif, > > + enum ieee80211_ampdu_mlme_action action, > > + struct ieee80211_sta *sta, u16 tid, u16 *ssn) > > +{ > > + struct wl1271 *wl = hw->priv; > > + int ret; > > + > > + ret = wl1271_ps_elp_wakeup(wl, false); > > + if (ret < 0) > > + goto out; > > + > > + switch (action) { > > + case IEEE80211_AMPDU_RX_START: > > + if (wl->ba_allowed) { > > + ret = wl1271_acx_set_ba_receiver_session(wl, tid, > ssn, > > + true); > > + if (!ret) > > + wl->ba_rx_bitmap |= (u8)(BIT(0) << tid); > > + } else > > + ret = -EPERM; > > + break; > > + > > + case IEEE80211_AMPDU_RX_STOP: > > + ret = wl1271_acx_set_ba_receiver_session(wl, tid, ssn, > false); > > + if (!ret) > > + wl->ba_rx_bitmap &= ~(u8)(BIT(0) << tid); > > + break; > > + > > + /* > > These "BIT(0) << tid" thingies look weird. Why not BIT(tid) ? > > -Juuso Good catch. Will be fix on v2. Thanks, Shahar ÿô.nlj·Ÿ®‰†+%ŠË±é¥Šwÿº{.nlj·¥Š{±ÿ«zW¬³ø¡Ü}©ž²ÆzÚj:+v‰¨þø®w¥þŠàÞ¨è&¢)ß«a¶Úÿûz¹ÞúŽŠÝjÿŠwèf
