On Wed, 2010-11-24 at 10:49 +0100, Johannes Berg wrote:
> On Wed, 2010-11-24 at 11:35 +0200, Eliad Peller wrote:
>
> > @@ -524,23 +423,14 @@ int wl1271_debugfs_init(struct wl1271 *wl)
> > {
> > int ret;
> >
> > - wl->debugfs.rootdir = debugfs_create_dir(KBUILD_MODNAME, NULL);
> > + wl->rootdir = debugfs_create_dir(KBUILD_MODNAME, NULL);
> >
> > - if (IS_ERR(wl->debugfs.rootdir)) {
> > - ret = PTR_ERR(wl->debugfs.rootdir);
> > - wl->debugfs.rootdir = NULL;
> > + if (IS_ERR(wl->rootdir)) {
> > + ret = PTR_ERR(wl->rootdir);
> > + wl->rootdir = NULL;
> > goto err;
> > }
>
> This looks problematic if you ever have more than one device ... I
> suggest moving to using the wiphy's debugfs dir as the parent for the
> rootdir.
But of course, that comment is entirely unrelated to _this_ patch.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
