Hi, the patch from Randy from [1] still applies, but my build-log from yesterday's linux-next shows: $ grep ^WARNING build_linux-next_next20101123.dileks.1.log | grep iwl WARNING: drivers/net/wireless/iwlwifi/iwlagn: 'iwl_legacy_tx_cmd_protection' exported twice. Previous export was in drivers/net/wireless/iwlwifi/iwl3945.ko WARNING: drivers/net/wireless/iwlwifi/iwlagn: 'iwl_isr_legacy' exported twice. Previous export was in drivers/net/wireless/iwlwifi/iwl3945.ko WARNING: drivers/net/wireless/iwlwifi/iwlagn: 'iwl_legacy_mac_bss_info_changed' exported twice. Previous export was in drivers/net/wireless/iwlwifi/iwl3945.ko WARNING: drivers/net/wireless/iwlwifi/iwlagn: 'iwl_legacy_mac_reset_tsf' exported twice. Previous export was in drivers/net/wireless/iwlwifi/iwl3945.ko WARNING: drivers/net/wireless/iwlwifi/iwlagn: 'iwl_legacy_mac_config' exported twice. Previous export was in drivers/net/wireless/iwlwifi/iwl3945.ko The fix is doing: [ drivers/net/wireless/iwlwifi/Makefile ] ... -iwlcore-$(CONFIG_IWL3945) += iwl-legacy.o -iwlcore-$(CONFIG_IWL4965) += iwl-legacy.o ... -iwlagn-$(CONFIG_IWL4965) += iwl-4965.o +iwlagn-$(CONFIG_IWL4965) += iwl-4965.o iwl-legacy.o ... -iwl3945-objs := iwl3945-base.o iwl-3945.o iwl-3945-rs.o iwl-3945-led.o +iwl3945-objs := iwl3945-base.o iwl-3945.o iwl-3945-rs.o iwl-3945-led.o iwl-legacy.o So why do I see warnings in iwl3945.ko but not in iwl-4965.ko? Is that fix still required? Fixed in wireless-next-2.6? Regards, - Sedat - [1] https://patchwork.kernel.org/patch/322492/ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
