On Fri, 2010-11-19 at 17:12 +0100, GÃbor Stefanik wrote:
> 2010/11/17 RafaÅ MiÅecki <zajec5@xxxxxxxxx>:
> > Devices which use LO enabled bit are covered by b43legacy
> >
> > Signed-off-by: RafaÅ MiÅecki <zajec5@xxxxxxxxx>
> > ---
> > V2: Dropped some not needed stuff as pointed by Michael, thanks!
> >
> > John: it's .38 ofc.
> > ---
> > drivers/net/wireless/b43/rfkill.c | 19 ++-----------------
> > 1 files changed, 2 insertions(+), 17 deletions(-)
> >
> > diff --git a/drivers/net/wireless/b43/rfkill.c b/drivers/net/wireless/b43/rfkill.c
> > index 78016ae..86bc0a0 100644
> > --- a/drivers/net/wireless/b43/rfkill.c
> > +++ b/drivers/net/wireless/b43/rfkill.c
> > @@ -28,23 +28,8 @@
> > /* Returns TRUE, if the radio is enabled in hardware. */
> > bool b43_is_hw_radio_enabled(struct b43_wldev *dev)
> > {
> > - if (dev->phy.rev >= 3 || dev->phy.type == B43_PHYTYPE_LP) {
> > - if (!(b43_read32(dev, B43_MMIO_RADIO_HWENABLED_HI)
> > - & B43_MMIO_RADIO_HWENABLED_HI_MASK))
> > - return 1;
> > - } else {
> > - /* To prevent CPU fault on PPC, do not read a register
> > - * unless the interface is started; however, on resume
> > - * for hibernation, this routine is entered early. When
> > - * that happens, unconditionally return TRUE.
> > - */
> > - if (b43_status(dev) < B43_STAT_STARTED)
> > - return 1;
> > - if (b43_read16(dev, B43_MMIO_RADIO_HWENABLED_LO)
> > - & B43_MMIO_RADIO_HWENABLED_LO_MASK)
> > - return 1;
> > - }
> > - return 0;
>
> Is there any reason why this bool originally returned 1 or 0 instead
> of true or false?
There's no difference.
(int)0 implicitly casts to false and anything else to true.
--
Greetings Michael.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
