Search Linux Wireless

Re: [PATCH 4/4] staging: brcm80211: brcmfmac: cleanup bcmsdh_(un)register

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 18, 2010 at 12:02:15AM +0200, Mike Rapoport wrote:
> On Wed, Nov 17, 2010 at 11:11 PM, Greg KH <greg@xxxxxxxxx> wrote:
> > On Wed, Nov 17, 2010 at 10:00:00AM +0200, Mike Rapoport wrote:
> >> Signed-off-by: Mike Rapoport <mike.rapoport@xxxxxxxxx>
> >> ---
> >>  drivers/staging/brcm80211/brcmfmac/bcmsdh_linux.c |   13 +------------
> >>  1 files changed, 1 insertions(+), 12 deletions(-)
> >>
> >> diff --git a/drivers/staging/brcm80211/brcmfmac/bcmsdh_linux.c b/drivers/staging/brcm80211/brcmfmac/bcmsdh_linux.c
> >> index fd327e1..e3fb7ed 100644
> >> --- a/drivers/staging/brcm80211/brcmfmac/bcmsdh_linux.c
> >> +++ b/drivers/staging/brcm80211/brcmfmac/bcmsdh_linux.c
> >> @@ -285,28 +285,17 @@ extern int sdio_function_init(void);
> >>
> >>  int bcmsdh_register(bcmsdh_driver_t *driver)
> >>  {
> >> -     int error = 0;
> >> -
> >>       drvinfo = *driver;
> >>
> >> -#if defined(BCMPLATFORM_BUS)
> >> -#if defined(BCMLXSDMMC)
> >>       SDLX_MSG(("Linux Kernel SDIO/MMC Driver\n"));
> >> -     error = sdio_function_init();
> >
> > Same question here, are you sure we can remove this code?
> 
> I'm not removing sdio_function_init here. I've only replaced
>         error = sdio_function_init();
>         return error;
> with
>         return sdio_function_init();

Doh, you are right, sorry about that, I missread the patch.

thanks

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux