On 11/17/10 08:49, Johannes Berg wrote: > On Wed, 2010-11-17 at 08:36 -0800, Guy, Wey-Yi wrote: >> Hi Randy, >> >> the "iwlwifi: fix modular legacy build errors" patch cause the following >> WARNING when compile > > I thought we already had had a fix for that issue anyway? Not that I know of. I reported a different build error and included a patch, which is now causing problems, so I asked John to drop/revert my patch. Here is part of the patch description that I sent: With CONFIG_IWLWIFI=m, CONFIG_IWLAGN=m, and CONFIG_IWL3945=m, a kernel build has errors as below. Changing a few lines in the Makefile is one possible fix for these build errors. ERROR: "iwl_legacy_mac_config" [drivers/net/wireless/iwlwifi/iwl3945.ko] undefined! ERROR: "iwl_isr_legacy" [drivers/net/wireless/iwlwifi/iwl3945.ko] undefined! ERROR: "iwl_legacy_tx_cmd_protection" [drivers/net/wireless/iwlwifi/iwl3945.ko] undefined! ERROR: "iwl_legacy_mac_bss_info_changed" [drivers/net/wireless/iwlwifi/iwl3945.ko] undefined! ERROR: "iwl_legacy_mac_reset_tsf" [drivers/net/wireless/iwlwifi/iwl3945.ko] undefined! So John can revert my patch and then let the iwlwifi maintainers fix this problem, please. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
