Am Dienstag 16 November 2010 schrieb Helmut Schaa: > Am Samstag 13 November 2010 schrieb Ivo van Doorn: > > From: RA-Jay Hung <Jay_Hung@xxxxxxxxxxxxxx> > > > > When send out skb data to mac80211, orignal code will cause mac80211 > > unaligned access, so modify code to make mac80211 can natural access. > > And this introduces the same panic again :( > > The problem is the following: > > We don't pass the skb in the same state back to mac80211 as we got it. > > When inserting the l2pad we're moving the header and thus reduce headroom. > This patch modifies the bahavior during l2pad removal to not move the header > back into its old position but instead moves the payload. Thus the skb keeps > the reduced headroom. If this skb gets requeued into rt2x00 (which can happen > when the frame wasn't acked and the according STA is known to e in powersave > mode) the header and payload get aligned again further reducing headroom which > results in a too small headroom for the TXWI and thus a skb_under_panic. Hmm, John merged that patch already. However, I would prefer if it would get reverted due to the occasional panics in AP mode. Jay, I didn't notice any performance degradation on MIPS, on which architecture did you test? Jay, Ivo, any objections against reverting this one? Thanks, Helmut -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
