> On Mon, Nov 15, 2010 at 02:16:06PM +0100, Wojciech Dubowik wrote: > > What about such changes compared to original patch? It's then > possible to > > compile both modules at the same time. Of course linking won't work > because > > I would need to separate functions like in ath9k. > > Is there a plan to add a config entry for ATHEROS_AR231X (or did > I miss it?) Someone will one day run their Kconfig checker and > report it missing. > Openwrt has whole implementation but I have no idea why it's not in the official kernel. Actually the same applies to ath9k because ATHEROS_AR71XX definition needed for AHB is not specified in latest kernel. http://www.mail-archive.com/ath9k-devel@xxxxxxxxxxxxxxx/msg03660.html > > --- a/drivers/net/wireless/ath/ath5k/Kconfig > > +++ b/drivers/net/wireless/ath/ath5k/Kconfig > > @@ -1,9 +1,11 @@ > > config ATH5K > > tristate "Atheros 5xxx wireless cards support" > > - depends on PCI && MAC80211 > > + depends on (PCI || ATHEROS_AR231X) && MAC80211 > > select MAC80211_LEDS > > select LEDS_CLASS > > select NEW_LEDS > > + select ATH5K_AHB if ATHEROS_AR231X > > + select ATH5K_PCI if PCI > > I like this better, but there probably needs to be a mutual > exclusion so that randconfig builds don't break. Then you don't > get to build both still, but the resulting Makefile is a bit more > normal. And then if someone shows up saying that they really do > have some AR231X device with PCI, then it's more obvious what they > need to do to fix it (i.e. separate bus interfaces from core). > > Something like? > select ATH5K_PCI if (PCI && !ATHEROS_AR231X) > or > depends on ((PCI && !ATHEROS_AR231X) || (!PCI && ATHEROS_AR231X)) ... I will make it exclusive and post in the the series if there are no more comments. Wojtek > > -- > Bob Copeland %% www.bobcopeland.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
