On Thu, Nov 11, 2010 at 1:18 PM, Luis R. Rodriguez <mcgrof@xxxxxxxxx> wrote: > On Thu, Nov 11, 2010 at 6:57 AM, Wojciech Dubowik <dubowoj@xxxxxxxxxxx> wrote: >> General comments for AHB bus support in ath5k: >> - most of the original patches came from Felix Fetikau. I have used them as a reference and ported to current git tree >> - tried with access point functionality with WPA2 and without encryption >> - tested on AR5312 for AHB and AR5414 and AR5212 for PCI >> - compat wireless from openwrt was used for testing these patches >> - last two patches have to be applied together because otherwise hardware will crash on reset if >> only number 9 is committed. I have kept them separated for better visibility > > Nice! You want to send these patches in a series as you have but use a > cover letter to introduce and explain the series. akpm would disagree :) > This patch's commit > log should only note that this uses the Generic DMA APIs in order to > later support AHB. You can get yourself a cover letter using git > format-patch --cover-letter. For more elaborate examples check out: ACK, the comments at the top should be in a cover letter or after the "---", or rewritten to be worth storing in the kernel history. Could you also cc ath5k-devel@xxxxxxxxxxxxxxx? Thanks for doing this work! -- Bob Copeland %% www.bobcopeland.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
