On Thu, Nov 11, 2010 at 6:57 AM, Wojciech Dubowik <dubowoj@xxxxxxxxxxx> wrote: > In main ath folder ath_bus_opts is used to specify AHB/PCI/USB specific functions. Use it for ath5k since it's needed for AHB support. > PCI initialization has been split to bus specific and common which have been moved to ath5k_attach. > > Signed-off-by: Wojciech Dubowik <Wojciech.Dubowik@xxxxxxxxxxx> Your patch commit log entry is way too long. Please trim it to around 76 characters per line or less. Also I'd prefer to help the reader of the code and make it clear that the work you do in ath5k_attach() is just to initialize the softc struct so please instead rename the routine to ath5k_init_softc() just as we do that in ath9k while you're at it. Later on (on a separate patch or series) you can also then rename ath5k_hw_attach() to ath5k_hw_init() as we did so on ath9k. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
