Hi John, folks. I've tried this with and without the change above
(obviously misapplied by me in the above case), and I have to say the
advantages (reducing number of events) is far outweighed by the
disadvantages (slower notification time), so I would vote to use the
first version of the patch in this thread, without the test for
IEEE80211_TX_CTL_RATE_CTRL_PROBE. That's what I'm running in my tree.
--
Paul
On Tue, Nov 9, 2010 at 1:40 PM, John W. Linville <linville@xxxxxxxxxxxxx> wrote:
> On Thu, Oct 21, 2010 at 08:58:12AM -0700, Paul Stewart wrote:
>> Am Donnerstag 21 Oktober 2010 schrieb Helmut Schaa:
>> > You might want to filter out probe frames based on
>> > IEEE80211_TX_CTL_RATE_CTRL_PROBE as otherwise you could end up with
>> > sending a huge number of events to userspace.
>>
>> Thanks, Helmut. I've incorporated your excellent suggestion. In practice
>> I have gotten reasonably modest rates of updates at the user side, but
>> filtering unnecessary stuff is definitely worthwhile.
>>
>> --
>>
>> Add state, work proc and debugging parameters for monitoring
>> transmit-rate changes.
>>
>> Signed-off-by: Paul Stewart <pstew@xxxxxxxxxx>
>
>> diff --git a/net/mac80211/status.c b/net/mac80211/status.c
>> index 3153c19..22c2c61 100644
>> --- a/net/mac80211/status.c
>> +++ b/net/mac80211/status.c
>> @@ -154,6 +154,24 @@ static void ieee80211_frame_acked(struct sta_info *sta, struct sk_buff *skb)
>> }
>>
>> ieee80211_queue_work(&local->hw, &local->recalc_smps);
>> + } else if (ieee80211_is_data(mgmt->frame_control) &&
>> + sdata->vif.type == NL80211_IFTYPE_STATION &&
>> + !(info->flags & IEEE80211_TX_CTL_RATE_CTRL_PROBE)) {
>> + struct ieee80211_if_managed *ifmgd = &sdata->u.mgd;
>> + if (ifmgd->cqm_bitrate_thold != 0 &&
>> + (ifmgd->last_cqm_tx_rate.idx != sta->last_tx_rate.idx ||
>> + (ifmgd->last_cqm_tx_rate.flags &
>> + (IEEE80211_TX_RC_MCS | IEEE80211_TX_RC_40_MHZ_WIDTH |
>> + IEEE80211_TX_RC_SHORT_GI)) !=
>> + (sta->last_tx_rate.flags &
>> + (IEEE80211_TX_RC_MCS | IEEE80211_TX_RC_40_MHZ_WIDTH |
>> + IEEE80211_TX_RC_SHORT_GI)) ||
>> + sdata->u.mgd.last_cqm_bitrate == 0)) {
>> + ifmgd->last_cqm_tx_rate = sta->last_tx_rate;
>> + ifmgd->tx_bitrate_changed = true;
>> + ieee80211_queue_work(&local->hw,
>> + &ifmgd->bitrate_notify_work);
>> + }
>> }
>> }
>
> CC [M] net/mac80211/status.o
> net/mac80211/status.c: In function ‘ieee80211_frame_acked’:
> net/mac80211/status.c:159: error: ‘info’ undeclared (first use in this function)
> net/mac80211/status.c:159: error: (Each undeclared identifier is reported only once
> net/mac80211/status.c:159: error: for each function it appears in.)
> make[1]: *** [net/mac80211/status.o] Error 1
> make: *** [net/mac80211/] Error 2
>
> --
> John W. Linville Someday the world will need a hero, and you
> linville@xxxxxxxxxxxxx might be all we have. Be ready.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
