* Luciano Coelho <luciano.coelho@xxxxxxxxx> [101108 01:05]: > On Sun, 2010-11-07 at 11:28 +0100, ext Kalle Valo wrote: > > Grazvydas Ignotas <notasas@xxxxxxxxx> writes: > > > > > Make use the newly added method to pass platform data for wl1251 too. > > > This allows to eliminate some redundant code. > > > > > > Cc: Tony Lindgren <tony@xxxxxxxxxxx> > > > Cc: Ohad Ben-Cohen <ohad@xxxxxxxxxx> > > > Signed-off-by: Grazvydas Ignotas <notasas@xxxxxxxxx> > > > > For the wl1251 part: > > > > Acked-by: Kalle Valo <kvalo@xxxxxxxxxx> > > > > > --- > > > This touches arch/arm/mach-omap2/* but I think it should go through > > > the wireless tree to avoid cross-tree dependencies, if Tony and others > > > are ok with this. > > > > I agree, better to push this through the wireless tree. > > > > > arch/arm/mach-omap2/board-omap3pandora.c | 32 +++++++------------------- > > > drivers/net/wireless/wl1251/sdio.c | 35 +---------------------------- > > > drivers/net/wireless/wl12xx/Kconfig | 2 +- > > > > We need to CC Luciano for the wl12xx change. > > > > > --- a/drivers/net/wireless/wl12xx/Kconfig > > > +++ b/drivers/net/wireless/wl12xx/Kconfig > > > @@ -42,5 +42,5 @@ config WL1271_SDIO > > > > > > config WL12XX_PLATFORM_DATA > > > bool > > > - depends on WL1271_SDIO != n > > > + depends on WL1271_SDIO != n || WL1251_SDIO != n > > > default y > > > > Oh, I didn't take this into account when I moved wl1251 out from the > > wl12xx directory. Now wl1251 has a dependency to wl12xx stuff. > > > > Oh well, it's a small issue. I guess we can live with that :) > > Yeah, I didn't realize this either. I think we can live with that, but > at some point we should clean this up and either have separate platform > data for wl1251 and wl12xx or move the the platform data one level up, > to wireless. But for now: > > Acked-by: Luciano Coelho <luciano.coelho@xxxxxxxxx> > > And I agree with pushing this through wireless-testing as well, if it's > okay with Tony and John. Yes, ack from me too: Acked-by: Tony Lindgren <tony@xxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
