Grazvydas Ignotas <notasas@xxxxxxxxx> writes: > Add runtime PM support, similar to how it's done for wl1271. > This allows to power down the card when the driver is loaded but > network is not in use. Few minor comments: > + /* Undo decrement done above in wl1271_probe */ Should be wl1251_probe(). > +static int wl1251_suspend(struct device *dev) > +{ > + /* > + * Tell MMC/SDIO core it's OK to power down the card > + * (if it isn't already), but not to remove it completely > + */ > + return 0; > +} Sorry, I'm not familiar with pm_ops and I don't fully understand the comment above. Does the comment mean that by returning 0 we can accomplish all that? Or instead is it a fixme comment that we should do that, but it's not implemented yet? -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html