On Thu, 2010-11-04 at 16:42 +0100, ext Johannes Berg wrote:
> On Mon, 2010-11-01 at 13:52 +0200, Luciano Coelho wrote:
>
> > + rtnl_lock();
> > +
> > + err = get_rdev_dev_by_info_ifindex(info, &rdev, &dev);
> > + if (err)
> > + goto out_rtnl;
> > +
> > + if (!netif_running(dev)) {
> > + err = -ENETDOWN;
> > + goto out;
> > + }
>
> ahem. we have infrastructure for this now.
Yeah, I noticed this. My implementation was originally done so far in
the past that this wasn't available then. I hadn't bothered changing it
yet, but I'll do it now.
>
> > + .doit = nl80211_start_periodic,
>
> > + .doit = nl80211_stop_periodic,
>
> > +void nl80211_send_periodic(struct cfg80211_registered_device *rdev,
> > + struct net_device *netdev, u32 cmd);
>
> I think you should add _scan to all these names.
I had _scan in all the names, but they got way too long and I couldn't
find a better way to do it shorter. But since you seem to prefer the
longer version with _scan, I'll change it back.
--
Cheers,
Luca.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
