Thanks for your review, Johannes! On Thu, 2010-11-04 at 16:51 +0100, ext Johannes Berg wrote: > On Mon, 2010-11-01 at 13:52 +0200, Luciano Coelho wrote: > > > This set doesn't support variable intervals, and the intervals > > need to be configure in the hw driver. > > which is wrong -- you really want that to be configurable. Yes, for sure I will. I'm already working on it. It's a requirement for us. > > This is an initial implementation and I'd like to get some comments before > > submitting the final version. > > > > I've split the implementation in many small patches, just to keep it clear > > and due to the zillions of times I've had to task switch while implementing > > this. I can merge some of them, if that makes things cleaner. > > Absolutely, the patch splitting is total crap :-) Heck, you even write > code only to remove/change it again! Indeed! I would never have accepted patches split up like this myself! :P My excuse is that I've been multitasking heavily lately and, knowing how buggy the task-switching implementation is in my brain, I reckoned it would be safer to commit often. Tomorrow I'll fix these issues and send a new version. -- Cheers, Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
