Search Linux Wireless

Re: [PATCH 6/7] mwl8k: choose proper firmware image as directed by user

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 2, 2010 at 1:30 AM, Lennert Buytenhek
<buytenh@xxxxxxxxxxxxxx> wrote:
> On Mon, Nov 01, 2010 at 05:55:50PM -0700, Brian Cavagnolo wrote:
>
>> The mwl8k can operate in AP or STA mode, depending on the
>> firmware image that is loaded.  Allow the user to specify
>> the desired firmware image at module load time.
>
> Strong NAK on selecting firmware image type with a module parameter,
> that's so wrong it's not even funny.
>
> Just use the STA image before ->add_interface() has been called if
> it is available.

The intention here is to save users who wish to only operate in AP
mode from sustaining an unnecessary firmware re-load.  Can you
elaborate on why it is unacceptable to achieve this with a module
parameter?  Perhaps just calling it ap_mode instead of want_ap_fw
makes more sense?

> And please switch to async firmware loading while you're at it.

Okay.

>> Also, the firmware image can be swapped to meet the user's
>> add_interface request.  For example, suppose the STA
>> firmware is loaded, no STA interface has been added, and the
>> user adds an AP interface.  In this case, the AP firmware
>> will be loaded to meet the request.
>>
>> Based on a patch from Pradeep Nemavat <pnemavat@xxxxxxxxxxx>
>
> Which was suggested by Lennert Buytenhek -- please give credit where
> it is due.
>

My apologies.  Understood.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux