On Wed, 2010-11-03 at 23:28 +0100, RafaÅ MiÅecki wrote: > Signed-off-by: RafaÅ MiÅecki <zajec5@xxxxxxxxx> > --- > As noticed my Michael we have this left from old times of limited amount of > revisions. It's not reliable to treat unknown as rev1. > > Michael: would you like to add Reported-by? Isn't that only for bugs? This isn't a bug. But you can add my acked-by, if that's desired. > John: it's for 2.6.38. > --- > drivers/ssb/pci.c | 8 +++----- > 1 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c > index b5343ac..41a7337 100644 > --- a/drivers/ssb/pci.c > +++ b/drivers/ssb/pci.c > @@ -600,11 +600,9 @@ static int sprom_extract(struct ssb_bus *bus, struct ssb_sprom *out, > sprom_extract_r8(out, in); > break; > default: > - ssb_printk(KERN_WARNING PFX "Unsupported SPROM" > - " revision %d detected. Will extract" > - " v1\n", out->revision); > - out->revision = 1; > - sprom_extract_r123(out, in); > + ssb_printk(KERN_ERR PFX "Unsupported SPROM revision %d" > + " detected\n", out->revision); > + return -EINVAL; > } > > if (out->boardflags_lo == 0xFFFF) -- Greetings Michael. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
