Search Linux Wireless

Re: [PATCH] ssb: workarounds: be verbose about hacking SPROM revision, don't duplicate code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2010-11-03 at 22:06 +0100, RafaÅ MiÅecki wrote: 
> +	default:
> +		ssb_printk(KERN_WARNING PFX "Unsupported SPROM"
> +			   "  revision %d detected. Will extract"
> +			   " v1\n", out->revision);
> +		out->revision = 1;
> +		sprom_extract_r123(out, in);

I think we should change this to throw a hard error if the sprom is
unknown. Extracting r123 is unlikely to do any good these days.
This workaround was only useful back in the days where 95% of the
cards out there were r123. But today that's not the case.

> 	}
>  
>  	if (out->boardflags_lo == 0xFFFF)


-- 
Greetings Michael.

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux