On Tue, Nov 02, 2010 at 01:50:07PM +0100, Johannes Stezenbach wrote: > > While reading through the code I noticed the following in rt2800_config_intf(): > > rt2x00_set_field32(®, MAC_BSSID_DW1_BSS_ID_MASK, 3); > > However, in Ralink source from http://www.ralinktech.com/support.php?s=2 > in DPO_RT3370_LinuxSTA_V2.4.0.1_20100831/include/chip/rtmp_mac.h it says: > USHORT BssIdMask:2; // 0: one BSSID, 10: 4 BSSID, 01: 2 BSSID , 11: 8BSSID > > This is different from rt73usb where 3 means "one BSSID". Any comments on this? I still have a very limited understanding of mac80211 and rt2xx code, but I'm reading through the code and report what looks suspicious to me. I hope that's OK? Here's another one: In rt2x00lib_rxdone(): /* * Allocate a new sk_buffer. If no new buffer available, drop the * received frame and reuse the existing buffer. */ skb = rt2x00queue_alloc_rxskb(rt2x00dev, entry); if (!skb) return; Should this not be "goto submit_entry;"? Johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
