Search Linux Wireless

Re: [PATCH] ath9k: Properly assign boolean types Signed-off-by: Mohammed Shafi Shajakhan <mshajakhan@xxxxxxxxxxx>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks , thought of that, but the code seems to use true/false approach, will send a new patch with this simple fix.
thanks,
shafi

On Monday 25 October 2010 09:28 PM, Ben Greear wrote:
On 10/25/2010 12:16 AM, Mohammed Shafi Shajakhan wrote:
From: Mohammed Shafi Shajakhan<mshajakhan@xxxxxxxxxxx>

---
   drivers/net/wireless/ath/ath9k/rc.c |    9 ++++++---
   1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/rc.c b/drivers/net/wireless/ath/ath9k/rc.c
index 0cee90c..0c70839 100644
--- a/drivers/net/wireless/ath/ath9k/rc.c
+++ b/drivers/net/wireless/ath/ath9k/rc.c
@@ -1444,12 +1444,15 @@ static void ath_rate_init(void *priv, struct ieee80211_supported_band *sband,
   		ath_rc_priv->neg_ht_rates.rs_nrates = j;
   	}

-	is_cw40 = sta->ht_cap.cap&   IEEE80211_HT_CAP_SUP_WIDTH_20_40;
+	is_cw40 = (sta->ht_cap.cap&   IEEE80211_HT_CAP_SUP_WIDTH_20_40) ?
+		true : false;
Maybe use:
is_cw40 = !!(sta->ht_cap.cap&   IEEE80211_HT_CAP_SUP_WIDTH_20_40);

Seems a bit simpler to me...

Ben


   	if (is_cw40)
-		is_sgi = sta->ht_cap.cap&   IEEE80211_HT_CAP_SGI_40;
+		is_sgi = (sta->ht_cap.cap&   IEEE80211_HT_CAP_SGI_40) ?
+			true : false;
   	else if (sc->sc_ah->caps.hw_caps&   ATH9K_HW_CAP_SGI_20)
-		is_sgi = sta->ht_cap.cap&   IEEE80211_HT_CAP_SGI_20;
+		is_sgi = (sta->ht_cap.cap&   IEEE80211_HT_CAP_SGI_20) ?
+			true : false

   	/* Choose rate table first */


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux