Search Linux Wireless

Re: [PATCH] b43: remove extraneous code in free_ringmemory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2010-10-25 at 10:24 -0400, John W. Linville wrote: 
> This code seems to have been cut-n-pasted from alloc_ringmemory?

No. It's leftover from the old SSB DMA mem allocator, which needed
the GFP flags.

> Anyway, it is useless.

ACK.

> Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx>
> ---
>  drivers/net/wireless/b43/dma.c |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/wireless/b43/dma.c b/drivers/net/wireless/b43/dma.c
> index 10d0aaf..3d5566e 100644
> --- a/drivers/net/wireless/b43/dma.c
> +++ b/drivers/net/wireless/b43/dma.c
> @@ -415,11 +415,6 @@ static int alloc_ringmemory(struct b43_dmaring *ring)
>  
>  static void free_ringmemory(struct b43_dmaring *ring)
>  {
> -	gfp_t flags = GFP_KERNEL;
> -
> -	if (ring->type == B43_DMA_64BIT)
> -		flags |= GFP_DMA;
> -
>  	dma_free_coherent(ring->dev->dev->dma_dev, B43_DMA_RINGMEMSIZE,
>  			  ring->descbase, ring->dmabase);
>  }


-- 
Greetings Michael.

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux