Correct, as far as I know. However, after I saw the parent->mutex bug, I did some digging, and found that in compat-wireless only one Atheros driver, which I do not use, actually uses those function calls (and doesn't use the trylock one). So I can't say that this code has actually been run. On Mon, Oct 25, 2010 at 9:49 AM, Luis R. Rodriguez <lrodriguez@xxxxxxxxxxx> wrote: > On Sun, Oct 24, 2010 at 1:41 PM, Blaise Gassend <blaise@xxxxxxxxxxxxxxxx> wrote: >> Hi Hauke, >> >>> in the Ubuntu 10.04 default kernel config CONFIG_PREEMPT_VOLUNTARY=y is >>> set, but it does not use the RT patches, so compat-wireless build >>> failed. If you are using a mainline kernel you can choose between >>> CONFIG_PREEMPT_NONE, CONFIG_PREEMPT_VOLUNTARY and CONFIG_PREEMPT (all >>> localed in kernel/Kconfig.preempt for a least kernel 2.6.24), so these >>> options are not indicating that the RT patches are applied. The RT patch >>> adds CONFIG_PREEMPT_RT and CONFIG_PREEMPT_DESKTOP and removes >>> CONFIG_PREEMPT, so choosing one of these options to detect that the RT >>> patch is applied is not a good idea. I do not had the time to look >>> through the hole rt patch to find a better indicator if it is applied so >>> I just removed the ones preventing compiling on normal kernels. I just >>> looked into patch-2.6.33.7-rt29.bz2 and not the other RT patches. >> >> OK, I see your point now. I did not realize that the mainstream >> kernels also had those two options in them. I haven't had much luck >> finding an config option that is always on in the RT kernels. For now >> your fix sounds like the right tradeoff. > > Just so we're clear, no further patch is needed ay? > > Luis > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
