On Mon, 2010-10-25 at 01:34 -0700, Stanislaw Gruszka wrote: > Hi Wey > > On Fri, Oct 22, 2010 at 08:23:05AM -0700, Guy, Wey-Yi wrote: > > On Fri, 2010-10-22 at 08:04 -0700, Stanislaw Gruszka wrote: > > > + if (WARN_ONCE(test_bit(STATUS_SCAN_HW, &priv->status), > > > + "TX Power requested while scanning!\n")) > > > + return -EIO; > > > > what reason we want to return -EIO instead of -EAGAIN? > > I though EAGAIN should be used for file nonblock I/O, but seems > it can be used anywhere when resources are unavailable. If it > make difference, we can apply this patch instead: > > From 7905309bfeae1a8374d3caa757d9f9383c15d700 Mon Sep 17 00:00:00 2001 > From: Stanislaw Gruszka <sgruszka@xxxxxxxxxx> > Date: Fri, 22 Oct 2010 13:23:41 +0200 > Subject: [PATCH 1/7 v2] iwlwifi: warn when send tx power settings during scan > > Add WARN_ONCE when scanning is pending. Use STATUS_SCAN_HW bit since we > can have scan canceled or completed but STATUS_SCANNING bit still set. > > v1 -> v2: replace EIO to EAGAIN > > Signed-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx> Acked-off-by: Wey-Yi Guy <wey-yi.w.guy@xxxxxxxxx> > --- -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
