W dniu 22 paÅdziernika 2010 23:38 uÅytkownik Larry Finger
<Larry.Finger@xxxxxxxxxxxx> napisaÅ:
> On 10/22/2010 03:24 PM, RafaÅ MiÅecki wrote:
>> Signed-off-by: RafaÅ MiÅecki <zajec5@xxxxxxxxx>
>> ---
>> This makes my N-PHY radio at least running (no scanning results so far). The
>> same register is used by wl on this device.
>> ---
>> Âdrivers/net/wireless/b43/rfkill.c | Â Â2 +-
>> Â1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/net/wireless/b43/rfkill.c b/drivers/net/wireless/b43/rfkill.c
>> index 78016ae..d2734c9 100644
>> --- a/drivers/net/wireless/b43/rfkill.c
>> +++ b/drivers/net/wireless/b43/rfkill.c
>> @@ -28,7 +28,7 @@
>> Â/* Returns TRUE, if the radio is enabled in hardware. */
>> Âbool b43_is_hw_radio_enabled(struct b43_wldev *dev)
>> Â{
>> - Â Â if (dev->phy.rev >= 3 || dev->phy.type == B43_PHYTYPE_LP) {
>> + Â Â if (dev->dev->id.revision >= 3) {
>> Â Â Â Â Â Â Â if (!(b43_read32(dev, B43_MMIO_RADIO_HWENABLED_HI)
>> Â Â Â Â Â Â Â Â Â Â & B43_MMIO_RADIO_HWENABLED_HI_MASK))
>> Â Â Â Â Â Â Â Â Â Â Â return
>
> As that register is present only when the core revision >= 3, this change should
> not cause a regression. Perhaps this was an error in the RE from the start and
> testing the phy.rev has always been wrong.
Do not blame RE team ;) It was described correctly since "ever", you
can check it in history of:
http://bcm-specs.sipsolutions.net/MMIO
I actually suspect this may be source of self-switching-on-off-radio
issue described in:
"b43legacy-phy3: Radio hardware status changed to XXX" thread.
I already mailed reporter to ask if he still has access to problematic card.
--
RafaÅ
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
