Search Linux Wireless

Re: [PATCH 3/6] Add a function for evaluating rate changes for possible notification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2010-10-13 at 15:13 -0700, Paul Stewart wrote:
> Called from a work proc, this examines the last transmit rate change
> to see if it warrants an event transmission.

> +        list_for_each_entry(sdata, &local->interfaces, list) {
> +                if (!netif_running(sdata->dev) ||

ieee80211_sdata_running

> +		if (!(ifmgd->flags & IEEE80211_STA_TX_RATE_CHANGED) ||
> +		    bss_conf->cqm_bitrate_thold == 0)
> +			continue;

why would this work item even be running with a threshold of zero?

Again, this won't compile without the next patch.

However, I think all of this is really expensive. For many devices,
you'll effectively be triggering an evaluation of the bitrate for every
packet. This will work well with minstrel, since it properly uses and
advertises the "best throughput" rate, but not necessarily with other
algorithms.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux