2010/10/13 BjÃrn Smedman <bjorn.smedman@xxxxxxxxxxx>: > Hi Ben, > > First of all keep up the good work. :) > > On Wed, Oct 13, 2010 at 6:39 PM, Ben Greear <greearb@xxxxxxxxxxxxxxx> wrote: > [snip] >> Either way, it seems safer to null out the bf_ampdu field after >> the memory is consumed..it could prevent some tricky bugs later. > > I think this is a good idea. But it probably wont be enough to null > out bf_mpdu. You also need to look at bf_buf_addr (which if I > understand correctly is the physical address the DMA engine will > actually write RXed frames to) and bf_dmacontext (which seems in most > cases to hold an identical address and may in fact be where the DMA > engine will really write the frame). See the TODO list for ath9k: * Remove this redundancy crap: bf->bf_buf_addr = bf->bf_dmacontext; http://wireless.kernel.org/en/users/Drivers/ath9k/todo Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html