On Tue, 2010-10-12 at 10:53 +0200, ext Ido Yariv wrote: > The number of entries in the TX queue is compared to the low watermark > value each time TX completion interrupts are handled. > However, the fact that a TX completion arrived does not necessarily mean > there are any less skbs in the TX queue. > > In addition, a TX completion interrupt does not necessarily mean that there > are any new available TX blocks. Thus, queuing TX work when the low > watermark is reached might not be needed. > > Fix this by moving the low watermark handling to the TX work function, > and avoid queuing TX work in this case. > > Signed-off-by: Ido Yariv <ido@xxxxxxxxxx> > --- > drivers/net/wireless/wl12xx/wl1271_tx.c | 35 +++++++++++++++++++----------- > 1 files changed, 22 insertions(+), 13 deletions(-) > This really could improve TX performance slightly - it allows the mac80211 to start tx'ing packets more aggressively after the driver buffer has reached the low watermark. The tx-pipeline will be constantly filled. Good work. Thanks for these patches! Reviewed-by: Juuso Oikarinen <juuso.oikarinen@xxxxxxxxx> -Juuso -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
