On Sun, 2010-10-10 at 17:24 +0200, ext Shahar Levi wrote:
> >> static const u8 *wl1271_band_rate_to_idx[] = {
> >> diff --git a/drivers/net/wireless/wl12xx/wl1271_rx.c
> b/drivers/net/wireless/wl12xx/wl1271_rx.c
> >> index 94da5dd..109a470 100644
> >> --- a/drivers/net/wireless/wl12xx/wl1271_rx.c
> >> +++ b/drivers/net/wireless/wl12xx/wl1271_rx.c
> >> @@ -53,6 +53,10 @@ static void wl1271_rx_status(struct wl1271 *wl,
> >> status->band = wl->band;
> >> status->rate_idx = wl1271_rate_to_idx(wl, desc->rate);
> >>
> >> + /* 11n support */
> >> + if (desc->rate <= CONF_HW_RXTX_RATE_MCS0)
> >> + status->flag |= RX_FLAG_HT;
> >> +
> >> status->signal = desc->rssi;
> >
> > Should this be #ifdef'ed also?
>
> No, in case of HT not supported the HW will not set MCS rate.
True, but if you don't have the ifdef you're adding unnecessary code in
the RX data path.
> >> diff --git a/drivers/net/wireless/wl12xx/wl1271_tx.c
> b/drivers/net/wireless/wl12xx/wl1271_tx.c
> >> index 1b8295c..af54fef 100644
> >> --- a/drivers/net/wireless/wl12xx/wl1271_tx.c
> >> +++ b/drivers/net/wireless/wl12xx/wl1271_tx.c
> >> @@ -236,6 +236,15 @@ u32 wl1271_tx_enabled_rates_get(struct wl1271
> *wl, u32 rate_set)
> >> rate_set >>= 1;
> >> }
> >>
> >> + /* MCS rates indication are on bits 16 - 23 */
> >> + rate_set >>= HW_HT_RATES_OFFSET - band->n_bitrates;
> >> +
> >> + for (bit = 0; bit < 8; bit++) {
> >> + if (rate_set & 0x1)
> >> + enabled_rates |= (CONF_HW_BIT_RATE_MCS_0 <<
> bit);
> >> + rate_set >>= 1;
> >> + }
> >> +
> >
> > And this? #ifdef here as well, maybe?
>
> No, in case of HT not supported MCS bit in rate_set will not be set.
Same here, this loop will add more CPU cycles in the TX data path
unnecessarily.
--
Cheers,
Luca.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
