Search Linux Wireless

Re: [Patch 1/1] wext: fix 32/64 bit alignment issue for 'point' type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2010-10-11 at 12:56 +0100, gerrit@xxxxxxxxxxxxxx wrote:
> > However, I don't understand this patch. Your original patch would have
> > fixed this just as well, since after it
> >
> > IW_EV_POINT_PK_LEN - IW_EV_LCP_PK_LEN
> >
> > would be
> >
> > (IW_EV_LCP_PK_LEN + 4) - IW_EV_LCP_PK_LEN == 4
> >
> > and at the same time fixes the userspace problem, if anyone really wants
> > to use wext in new applications that don't use iwlib still...
> >
> Good catch, this is much better (I got lost in all the other constants).
> I will check if I have not missed anything and resubmit if there are no
> side effects.

Alright, thanks. I'm pretty sure you can't have missed anything, since
git grep for the constant shows only this single use, and iwlib ships a
header file that already contains your correction :-)

I'm not sure if there's a real or perceived length limit on git commit
logs, but it might be nice to archive your discussion of the problem
(today's, I mean) in the git log.

Anyway, thanks for investigating this!

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux