Search Linux Wireless

Re: [PATCH v2 01/03] wl1271: 11n Support, Add Definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2010-10-07 at 20:20 +0200, ext Luciano Coelho wrote:
> > diff --git a/drivers/net/wireless/wl12xx/wl1271_conf.h
> b/drivers/net/wireless/wl12xx/wl1271_conf.h
> > index 60c50d1..732e9aa 100644
> > --- a/drivers/net/wireless/wl12xx/wl1271_conf.h
> > +++ b/drivers/net/wireless/wl12xx/wl1271_conf.h
> > @@ -91,6 +91,10 @@ enum {
> >       CONF_HW_RXTX_RATE_UNSUPPORTED = 0xff
> >  };
> >  
> > +#define HW_RX_HIGHEST_RATE   65
> > +#define HW_BG_RATES_MASK     0xffff
> > +#define HW_HT_RATES_OFFSET   16
> 
> We preceed all the other macros with CONF_, please do the same for
> these.

Actually, we use the wl1271_conf.h file only for driver configuration
parameters.  These macros should be elsewhere, such as in the wl1271.h
file.  And no need to put CONF_ before them in that case.

-- 
Cheers,
Luca.

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux