On Wed, Oct 06, 2010 at 01:46:18PM +0200, Johannes Berg wrote: > On Wed, 2010-10-06 at 13:43 +0200, Christian Lamparter wrote: > > > > Basically the thing is that until your patch, the data in the struct > > > didn't actually need locking because it was accessed by the RX path only > > > which is not concurrent. > > > > > I see. So basically all rx handlers are affected by these rx->sta races. > > > > John, can you please revert (or at least drop from the upcoming 2.6.37-rcX cycle): > > > > (mac80211: fix release_reorder_timeout in scan) > > mac80211: fix rcu-unsafe pointer dereference > > mac80211: AMPDU rx reorder timeout timer > > (mac80211: remove unused rate function parameter) > > mac80211: put rx handlers into separate functions > > I think it's probably easier to fix than to revert now? There are only a > handful of fields, and it seemed to me that most of them can easily be > moved under the reorder lock. I would prefer a fix on top rather than a series of reverts... John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
