Search Linux Wireless

Re: [PATCH] mac80211: hoist sta->lock from reorder release timer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2010-10-06 at 12:00 +0200, Christian Lamparter wrote:

> The timer itself is part of the station's private struct.
> The clean-up routine will deactivate the timer as soon as
> the station is removed. Therefore the extra sta->lock
> protection should not be necessary.

>  	rcu_read_lock();
> -	spin_lock(&sta->lock);
>  	ieee80211_release_reorder_timeout(sta, *ptid);
> -	spin_unlock(&sta->lock);
>  	rcu_read_unlock();

There's a comment on ieee80211_release_reorder_timeout() saying that the
lock must be held -- which is probably not true? We don't generally hold
that lock on the RX path...?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux