On 10/05/2010 01:41 PM, Johannes Berg wrote:
On Tue, 2010-10-05 at 13:36 -0700, Ben Greear wrote:
I've reproduced the scenario and tested the fix.
This fixes the crash reported at
http://mid.gmane.org/4CAB6F96.6090701@xxxxxxxxxxxxxxx
I can no longer reproduce that problem, so it looks fixed
to me.
Yeah .. I did actually go and reproduce the crash by strategically
adding an msleep(200) to the mac80211 code and then doing some things
from userspace :-)
The data corruption issue still exists, however...
That looks very much like an ath9k issue, it seems like it's doing DMA
into already freed SKBs. Come to think of it, maybe that wmb() patch
might help?:
I can try it. I've been trying to crawl through the rx path line by line,
and once you get into mac80211, it's a real slow slog for me :)
For what it's worth, ath9k looked pretty clean to me, but if it's
something clever like wmb() stuff, then I wouldn't notice anyway...
Thanks,
Ben
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
