On Monday 04 October 2010 19:52:12 Ben Greear wrote: > On 09/14/2010 01:51 PM, Christian Lamparter wrote: > > On Sunday 05 September 2010 11:32:26 Ming Lei wrote: > >> Seems the warning does not affect use of wireless, false positive? > > > > No, it's a bug... but please read& test the attached patch. > > This is not yet in wireless-testing. Should it be? have you heard anything from Ming Lei about this subject? Or have you reproduced the bug too? > > --- > > [PATCH] mac80211: hoist sta->lock from reorder release timer > > > > The patch "mac80211: AMPDU rx reorder timeout timer" clashes > > with "mac80211: use netif_receive_skb in ieee80211_rx callpath" > > > > The timer itself is part of the station's private struct and > > it gets killed whenever the station is removed. Therefore > > the extra sta->lock protection (that can interferes with the > > tx path) is not necessary. > > > > Reported-by: Ming Lei<tom.leiming@xxxxxxxxx> > > Signed-off-by: Christian Lamparter<chunkeey@xxxxxxxxxxxxxx> > > --- > > diff --git a/net/mac80211/agg-rx.c b/net/mac80211/agg-rx.c > > index 58eab9e..309ed70 100644 > > --- a/net/mac80211/agg-rx.c > > +++ b/net/mac80211/agg-rx.c > > @@ -129,9 +129,7 @@ static void sta_rx_agg_reorder_timer_expired(unsigned long data) > > timer_to_tid[0]); > > > > rcu_read_lock(); > > - spin_lock(&sta->lock); > > ieee80211_release_reorder_timeout(sta, *ptid); > > - spin_unlock(&sta->lock); > > rcu_read_unlock(); > > } > > > > -- -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
