Search Linux Wireless

Re: [PATCH 2/4] ath9k_hw: merge codepaths that access the cycle counter registers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4 October 2010 14:34, Vasanthakumar Thiagarajan <vasanth@xxxxxxxxxxx> wrote:

>> +
>> +     /* prevent wraparound */
>> +     if (ah->cc.cycles & BIT(31))
>> +             clear = true;
>
> This does not look right, previous if should take care of
> any wrap around.

I was just in this area of the FreeBSD ath HAL code last week.

I wonder why you don't just poll the values periodically and store
them in a history array. Would you need to handle wrap-around if
you're already polling the values every 100ms?


Adrian
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux