On Wed, 2010-09-29 at 13:21 -0700, Ben Greear wrote:
> On 09/28/2010 11:59 PM, Johannes Berg wrote:
> > On Tue, 2010-09-28 at 17:30 -0700, greearb@xxxxxxxxxxxxxxx wrote:
> >
> >> -#define PARSE_BEACON_CHAN(_attr, _chan) do { \
> >> - r = parse_beacon_hint_chan(tb[_attr], \
> >> - &_chan); \
> >> - if (r) \
> >> - return NL_SKIP; \
> >> -} while (0)
> >> +
> >> +#define PARSE_BEACON_CHAN(_attr, _chan) do { \
> >> + r = parse_beacon_hint_chan(tb[_attr], \
> >> + &_chan); \
> >> + if (r) { \
> >> + fflush(stdout); \
> >> + return NL_SKIP; \
> >> + } \
> >> + } while (0)
> >> +
> >
> > Why does that need fflush() here? We'll eventually finish that line, no?
>
> This returns from the print_event method, so I assume it should
> flush. If it finishes the line, I'm not sure where.
Oh, you're right, I'll apply this too, and then I'll have done your
three changes in three changesets, heh... oh well :)
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
