On Tue, 2010-09-28 at 14:39 +0300, juuso.oikarinen@xxxxxxxxx wrote: > From: Juuso Oikarinen <juuso.oikarinen@xxxxxxxxx> > > The WMM parameter configuration function (ieee80211_sta_wmm_params) only > configures the WMM parameters to the driver is the wmm_last_param_set > counter value is changed by the AP. > > The wmm_last_param_set is initialized to -1 on association in order to ensure > the configuration is made to the driver at least once on association, but > currently this initialization is done *after* the WMM parameter configuration > function was called. > > This leads to unreliability in the driver getting properly configured on first > association (depending on what counter value the AP happens to use.) When > disassociating (the wmm default parameters are configured to the driver) and > then reassociating, due to the above the WMM configuration is not set to the > driver at all. > > On drivers without beacon filtering the problem is corrected by later beacons, > but on drivers with beacon filtering the WMM will remain permanently incorrectly > configured. > > Fix this by moving the initialization of wmm_last_param_set to -1 before > ieee80211_sta_wmm_params is called on association. Good catch! Acked-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
