On Mon, 2010-09-27 at 11:12 +0200, ext Johannes Berg wrote:
> On Mon, 2010-09-27 at 11:37 +0300, Luciano Coelho wrote:
> > From: Juuso Oikarinen <juuso.oikarinen@xxxxxxxxx>
> >
> > This patch adds support for the hardware GEM cipher suite.
> >
> > Signed-off-by: Juuso Oikarinen <juuso.oikarinen@xxxxxxxxx>
> > Reviewed-by: Luciano Coelho <luciano.coelho@xxxxxxxxx>
> > Signed-off-by: Luciano Coelho <luciano.coelho@xxxxxxxxx>
> > ---
> > drivers/net/wireless/wl12xx/wl1271.h | 2 ++
> > drivers/net/wireless/wl12xx/wl1271_cmd.h | 2 +-
> > drivers/net/wireless/wl12xx/wl1271_main.c | 16 ++++++++++++++++
> > 3 files changed, 19 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/net/wireless/wl12xx/wl1271.h b/drivers/net/wireless/wl12xx/wl1271.h
> > index 763ece8..9782bc1 100644
> > --- a/drivers/net/wireless/wl12xx/wl1271.h
> > +++ b/drivers/net/wireless/wl12xx/wl1271.h
> > @@ -117,6 +117,8 @@ enum {
> > #define WL1271_TX_SECURITY_LO16(s) ((u16)((s) & 0xffff))
> > #define WL1271_TX_SECURITY_HI32(s) ((u32)(((s) >> 16) & 0xffffffff))
> >
> > +#define WL1271_CIPHER_SUITE_GEM 0x000FACFF
>
> NACK, this is a standards-reserved value. Use the correct ID for it or
> allocate one within your own OUI if you don't want to admit what this
> really is (and by now all readers here will know anyway.)
Well I'm sure many or most know what this patch is about. The choice of
value was not intended to hide that.
You're right though, we'll need to change the OUI of the value, unless
you can point me to an official value to use.
-Juuso
> johannes
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
